Conversation
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
| - alias: postgresql | ||
| condition: postgresql.enabled | ||
| name: postgresql-ha | ||
| repository: oci://registry-1.docker.io/bitnamicharts | ||
| version: 15.3.17 | ||
| - condition: redis.enabled | ||
| name: redis | ||
| repository: oci://registry-1.docker.io/bitnamicharts | ||
| version: 22.0.7 |
There was a problem hiding this comment.
I would say we should open a github issue to move away from bitnami: bitnami/charts#35164
There was a problem hiding this comment.
Do any of these values apply to this chart? if not, then it belongs in solo and not in solo-charts/solo-shared-resources
There was a problem hiding this comment.
this appears to be configurations needed for mirror node. I would say anything mirror node related belongs in Solo, not in solo-charts.
It is okay to store the redis information, so that solo can look it up to create the secrets needed for mirror node
There was a problem hiding this comment.
this appears to be configurations needed for mirror node. I would say this belongs in Solo, not in solo-charts.
| {{ if .Values.postgresql.enabled -}} | ||
| admin-password: {{ coalesce .Values.postgresql.pgpool.adminPassword (get $passwords "admin-password" | default "" | b64dec) (randAlphaNum 40) | quote }} | ||
| PGPOOL_POSTGRES_CUSTOM_PASSWORDS: "{{ $graphqlPassword }},{{ $grpcPassword }},{{ $importerPassword }},{{ $ownerPassword }},{{ $restPassword }},{{ $restJavaPassword }},{{ $rosettaPassword }},{{ $web3Password }}" | ||
| PGPOOL_POSTGRES_CUSTOM_USERS: "{{ $graphqlUsername }},{{ $grpcUsername }},{{ $importerUsername }},{{ $ownerUsername }},{{ $restUsername }},{{ $restJavaUsername }},{{ $rosettaUsername }},{{ $web3Username }}" | ||
| password: {{ coalesce .Values.postgresql.postgresql.password (get $passwords "password" | default "" | b64dec) (randAlphaNum 40) | quote }} | ||
| repmgr-password: {{ coalesce .Values.postgresql.postgresql.repmgrPassword (get $passwords "repmgr-password" | default "" | b64dec) (randAlphaNum 40) | quote }} | ||
| POSTGRESQL_TIMEZONE: "UTC" | ||
| {{ end -}} |
There was a problem hiding this comment.
I think this section makes sense to keep, but all of the mirror node settings does not belong here.
3 participants
Description
This PR adds a new chart used for deploying shared resources - Postgres and Redis.
The current implementation copies and modifies the
hedera-mirrorchart from the Mirror node.