chore: polish up state management

[brunodam]

Description

This pull request introduces two main improvements: enhanced backward compatibility for configuration files and a fix for Helm integration with Kubernetes regarding field manager name length. It also adds comprehensive tests to ensure these changes work as intended.

Configuration Backward Compatibility:

• Added automatic migration of deprecated config fields (release, chart) to their new names (releaseName, chartRepo) for backward compatibility, along with deprecation warnings. (internal/config/config.go [1] internal/config/migration.go [2]
• Added tests to verify migration logic, correct handling of both old and new config fields, and precedence of new field names. (internal/config/config_test.go internal/config/config_test.goR58-R176)

Helm Field Manager Name Fix:

• Implemented logic to truncate the Kubernetes field manager name used by Helm to a maximum of 128 bytes, preventing API rejections due to overly long names (especially when running tests or in certain IDEs). (pkg/helm/helpers.go [1] [2]
• Added tests to ensure the truncation logic works correctly with various path lengths and real-world scenarios. (pkg/helm/helpers_test.go pkg/helm/helpers_test.goR1-R83)

Minor Fixes:

• Fixed a bug in a test setup by passing the correct value type to SetupHomeDirectoryStructure. (internal/workflows/steps/step_setup_directories_test.go internal/workflows/steps/step_setup_directories_test.goL20-R20)

Related Issues

• Closes Polish up block node install with state management #322

[Copilot]

Pull request overview

This pull request enhances backward compatibility for configuration files and fixes a Helm integration issue with Kubernetes field manager name length constraints. It also corrects a minor test setup bug.

Changes:

• Implements automatic migration of deprecated config fields (release, chart) to new names (releaseName, chartRepo) with deprecation warnings
• Adds field manager name truncation logic to prevent Kubernetes API rejections when running tests or in certain IDEs
• Fixes incorrect parameter type in test setup by dereferencing the pointer

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
internal/config/migration.go	Adds backward compatibility logic for migrating deprecated config field names with deprecation warnings
internal/config/config.go	Integrates migration logic into the configuration initialization process
internal/config/config_test.go	Adds comprehensive tests for config migration including old fields, new fields, and precedence
pkg/helm/helpers.go	Implements field manager name truncation to comply with Kubernetes 128-byte limit
pkg/helm/helpers_test.go	Adds tests for field manager truncation logic
internal/workflows/steps/step_setup_directories_test.go	Fixes test by correctly dereferencing WeaverPaths pointer

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.