feat: add --skip-hardware-checks hidden option

[brunodam]

Description

This pull request introduces a hidden CLI flag, --unsafe-skip-hardware-checks, which allows users to bypass hardware validation checks (CPU, memory, storage) during installation workflows for block nodes and Kubernetes clusters. The flag is intended for advanced use cases such as development, testing, or working around false-positive hardware check failures. The implementation ensures that other critical checks (privilege, user, host profile, OS) still run, and the flag is not available for the check command to maintain system safety. Documentation has also been added to clarify the flag's purpose and usage.

The most important changes are:

Feature: Add hidden flag to skip hardware checks

• Introduced the --unsafe-skip-hardware-checks flag as a hidden persistent flag on the root command, with clear warnings about its risks and intended use. The flag is documented and registered in flags.go and root.go. [1] [2] [3] [4]

Workflow updates to support the new flag

• Updated workflow constructors (InstallClusterWorkflow, NewBlockNodeInstallWorkflow, NodeSetupWorkflow, NewNodeSafetyCheckWorkflow) to accept and propagate the skipHardwareChecks boolean, ensuring hardware validation steps are conditionally included or excluded. [1] [2] [3] [4]

Command changes to wire the flag into install workflows

• Modified the block node install and kube cluster install commands to read the new flag and pass its value into the workflow chain, enabling hardware check skipping when requested. [1] [2]

Testing and documentation

• Updated integration tests and added developer documentation (hidden-flags.md) detailing the flag’s scope, use cases, and implementation. [1] [2]

Logging and messaging

• Added logging to warn users when hardware checks are skipped, increasing visibility of potentially unsafe operations.

These changes collectively provide a controlled, well-documented mechanism to bypass hardware checks for advanced scenarios while preserving safety for standard operations.

Related Issues

• Closes Implement administrative override switch which allows installing even if the safety checks are failing #372

[Copilot]

Pull request overview

This pull request introduces a hidden CLI flag --unsafe-skip-hardware-checks that allows users to bypass hardware validation checks during installation workflows. The flag is designed for advanced use cases such as development, testing, or working around false-positive hardware check failures. The implementation includes flag registration, workflow modifications, command updates, and comprehensive documentation.

Changes:

• Added a hidden persistent flag --unsafe-skip-hardware-checks registered on the root command that skips hardware validation steps during installation
• Modified workflow constructors to accept and propagate a skipHardwareChecks boolean parameter through the workflow chain
• Updated install commands to read the flag value and pass it to workflows

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
cmd/weaver/commands/common/flags.go	Defined the FlagUnsafeSkipHardwareChecks flag with documentation
cmd/weaver/commands/root.go	Registered the flag as a hidden persistent flag on the root command
cmd/weaver/commands/block/node/install.go	Read the flag value and pass it to the block node install workflow
cmd/weaver/commands/kube/cluster/install.go	Read the flag value and pass it to the cluster install workflow
internal/workflows/preflight.go	Modified NewNodeSafetyCheckWorkflow to conditionally skip hardware checks based on the flag
internal/workflows/setup.go	Updated NodeSetupWorkflow to accept and propagate the skipHardwareChecks parameter
internal/workflows/cluster.go	Updated InstallClusterWorkflow to accept and propagate the skipHardwareChecks parameter
internal/workflows/blocknode.go	Updated NewBlockNodeInstallWorkflow to accept and propagate the skipHardwareChecks parameter
internal/workflows/cluster_it_test.go	Updated integration test to pass false for the new skipHardwareChecks parameter
docs/dev/hidden-flags.md	Added documentation describing the flag's purpose, scope, and implementation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.