Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix pagination bug in Tines connector (related to #52). #60

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

hcpadkins
Copy link
Contributor

Overview

This pull-request resolves a bug reported by @britton-from-notion in #52. This has been validated to resolve the reported issue in a local reproduction environment.

Basically, it's a silly bug where the page number is being incorrectly set to the value of next_page rather than next_page_number - where one is a URI, and the other is an integer.

As a result, we're passing a URI to the page directive of the Tines API, rather than just an integer. Looking at my old test fixtures, it appears that this next_page_number field is "new", but it appears that the next_page field was always a URI so it was still an error in the connector. We just never triggered it as the event load when using the connector was always less than 500-events per run interval.

Unfortunately, it seems like the Tines API is silently accepting a URL in the page field, but appears to be ignoring the value entirely and just returning the first page ad-infinitum.

@hcpadkins hcpadkins requested a review from a team as a code owner October 8, 2024 12:28
Copy link
Contributor

@TheRealSpencer TheRealSpencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hcpadkins hcpadkins merged commit 8e95b8f into hashicorp-forge:main Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants