update aws/docker/kube for 0.12 release #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| provider "aws" { | |||
| version = "~> 3.0" | |||
| region = "us-east-1" | |||
| region = "eu-west-2" | |||
There was a problem hiding this comment.
Was this change intentional? us-east-1 is pretty standard, no?
There was a problem hiding this comment.
sorry, didnt notice I commited that change, I just use my nearest neighbou, no need to change at all.
| @@ -19,7 +19,7 @@ services: | |||
| retries: 5 | |||
|
|
|||
| db-init: | |||
| image: hashicorp/boundary:0.9.0 | |||
| image: hashicorp/boundary | |||
There was a problem hiding this comment.
Should we not make this explicitly 0.12.0 since this guide is written with that in mind?
There was a problem hiding this comment.
my thought process was that it would make it easier to reuse this bit of code for future releases, hence why I dropped the version tag.
I thought about using an env file as well but happy either way
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've update the AWS , Docker , Kubernetes TF code to work on latests version of Boundary including the updated TF provider with hosts sources instead of host sets on targets.
I also added a facilitator to get the correct boundary version on the AWS documentation.
as well as added tf outputs on all code to facilitate getting started with boundary after a succesfull TF run.
as well as a "destroy-tf-run" helped to ease clean up of resources. (without it the resources get destroyed before boundary resources and a destroy run fails)