Add cache support for none keyring type #3692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exporting FlagOutputCurlString allows other commands that embed the base.Command to access the flag as needed
This new command will support both managing and searching the local CLI cache daemon.
* Add persona table and move files to new directories
* Add unix socket listen and dialers with file permissions applied * Update the pathing to match RFC
* Separate daemon from server * Add persona handler to daemon server (#3579)
* search uses hashicorp/mql
* exec.Command for background process * Log to stderr when in foreground and file always * Use pid files across platform for start and stop
* requests with version info must match daemons
upgrade go-dbw deps and add cgo build tags
talanknight
force-pushed
the
alanknight_cache_sessions
branch
from
01bdb06
to
26a53d8
Compare
talanknight
force-pushed
the
alanknight_keyringless_personas
branch
from
bfa744c
to
2516dd6
Compare
talanknight
force-pushed
the
alanknight_cache_sessions
branch
2 times, most recently
from
4790b97
to
3e8f34c
Compare
Base automatically changed from
alanknight_cache_sessions
to
llb-client-daemon
September 14, 2023 17:01
talanknight
force-pushed
the
llb-client-daemon
branch
from
65212b6
to
b119caa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository now stores a map of auth token ids to auth tokens used when refreshing the cache with for personas that are not stored in the keystore. The map is cleaned up any time a persona might have been deleted, like when removing stale personas, or when adding a persona beyond the maximum number of personas trackable by the cache.
When a keyring type is set to none the token name and the auth token id must match. That token name is then used for updating information related to the last time the token was used by the CLI.
Leaving this a draft PR just because the branch this is based off of is already based off of another branch waiting to be reviewed and merged into llb-client-daemon so significant changs might be needed while those other PRs get reviewed.