Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Limit Configuration #3813

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Rate Limit Configuration #3813

merged 2 commits into from
Oct 11, 2023

Conversation

tmessi
Copy link
Member

@tmessi tmessi commented Oct 9, 2023

This PR adds the configuration structure for API rate limiting

@github-actions github-actions bot added the core label Oct 9, 2023
@tmessi tmessi marked this pull request as ready for review October 9, 2023 23:34
mgaffney
mgaffney approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@mgaffney mgaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few spelling errors

internal/cmd/config/config.go Outdated Show resolved Hide resolved
internal/ratelimit/config.go Outdated Show resolved Hide resolved
internal/ratelimit/config.go Outdated Show resolved Hide resolved
@tmessi tmessi merged commit 982bc6a into llb-rate-limiting Oct 11, 2023
49 checks passed
@tmessi tmessi deleted the tmessi-rate-limit branch October 11, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaffney mgaffney mgaffney approved these changes

@jimlambrt jimlambrt jimlambrt approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmessi @mgaffney @jimlambrt