Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ListResolvableAliases to the user service #4609

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Add ListResolvableAliases to the user service #4609

merged 6 commits into from
Apr 17, 2024

Commits on Apr 16, 2024

  1. Add ListResolvableAliases to the user service 

    There are a few non common ways this method uses our ACL
and grant system. A user is able to list resolvable
aliases for another user if they are granted permission
to do so. That means we had to load the grants for
the user being listed for anot not the requester when
determining if an alias is able to resolve to a destination
for which the requested user has permission.

Similarly, the grant hash used for the list pagination
is required to be that of the user being listed and not
the requester.
    @talanknight
    talanknight committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3c0c68d View commit details
    Browse the repository at this point in the history

  2. Don't pass in filter function into domain service

    @talanknight
    talanknight committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    71f5cc8 View commit details
    Browse the repository at this point in the history

  3. Fix test race conditions for errors

    @talanknight
    talanknight committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8ef1d38 View commit details
    Browse the repository at this point in the history

  4. now returns even targets with noop action permissions

    @talanknight
    talanknight committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e24f8cb View commit details
    Browse the repository at this point in the history

  5. reviewer comments

    @talanknight
    talanknight committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    28a94d6 View commit details
    Browse the repository at this point in the history

  6. fixup! reviewer comments

    @talanknight
    talanknight committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ce35e22 View commit details
    Browse the repository at this point in the history