Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix data race in hclogger #4645

Merged
merged 2 commits into from
Apr 17, 2024
Merged

bug: fix data race in hclogger #4645

merged 2 commits into from
Apr 17, 2024

Conversation

irenarindos
Copy link
Collaborator

No description provided.

@irenarindos irenarindos added this to the 0.16.x milestone Apr 15, 2024
@irenarindos irenarindos marked this pull request as ready for review April 15, 2024 18:05
@irenarindos irenarindos requested a review from moduli April 15, 2024 18:06
@github-actions github-actions bot added the core label Apr 15, 2024
johanbrandhorst
johanbrandhorst approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a comment to the l field in the struct to explain that it's protecting the signer field? It wasn't clear to me until I'd read this whole file why we needed the lock.

@irenarindos irenarindos merged commit 0160258 into main Apr 17, 2024
63 checks passed
@irenarindos irenarindos deleted the irindos-event-data-race branch April 17, 2024 18:53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

@moduli moduli Awaiting requested review from moduli

Assignees
No one assigned
Labels
backport/0.16.x core
Projects
None yet
Milestone
0.16.x
Development

Successfully merging this pull request may close these issues.
3 participants
@irenarindos @johanbrandhorst @moduli