refact: to use go-dbw CreateItems, DeleteItems #4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/iam
core/db
core/oplog
core/auth
core/session
core
core/host
core/target
core/server
labels
jimlambrt
force-pushed
the
jimlambrt-go-dbw-batch-ops
branch
from
1ae6fde
to
c6e3a49
Compare
jimlambrt
force-pushed
the
jimlambrt-go-dbw-batch-ops
branch
from
c6e3a49
to
8b8d2f5
Compare
jimlambrt
force-pushed
the
jimlambrt-go-dbw-batch-ops
branch
2 times, most recently
from
97cebcf
to
0d9b9ce
Compare
Latest version of go-dbw updated the signature of CreateItems(...) and DeleteItems(...) on a happy note this latest version of go-dbw actually does batch inserts and updates for this functions.
jimlambrt
force-pushed
the
jimlambrt-go-dbw-batch-ops
branch
from
0d9b9ce
to
8f2b06b
Compare
jefferai
pushed a commit
that referenced
this pull request
Sep 11, 2024
* refact: to use go-dbw CreateItems, DeleteItems Latest version of go-dbw updated the signature of CreateItems(...) and DeleteItems(...) on a happy note this latest version of go-dbw actually does batch inserts and updates for this functions. * all: regenerate protos with new protoc-gen-go version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of go-dbw updated the signature of CreateItems(...) and DeleteItems(...) on a happy note this latest version of go-dbw actually does batch inserts and updates for this functions.
**Do not merge until go-dbw #57 is merged and we update the go-dbw to a released version. **