Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refuse to backport if migrations changed #5035

Merged
merged 1 commit into from
Aug 23, 2024
Merged

ci: refuse to backport if migrations changed #5035

merged 1 commit into from
Aug 23, 2024

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Aug 21, 2024 •
edited
Loading

@johanbrandhorst johanbrandhorst added backport/0.5.x Backport changes to `release/0.5.x` and removed core/db core core/sql labels Aug 21, 2024
@johanbrandhorst johanbrandhorst added backport/0.16.x and removed backport/0.5.x Backport changes to `release/0.5.x` backport/0.16.x labels Aug 21, 2024
@johanbrandhorst johanbrandhorst force-pushed the jbrandhorst-refuse-backports-of-migrations branch from e4d7466 to 759aff4 Compare August 21, 2024 22:25
@johanbrandhorst johanbrandhorst added this to the 0.18.x milestone Aug 21, 2024
@johanbrandhorst johanbrandhorst marked this pull request as ready for review August 21, 2024 22:26
moduli
moduli approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@moduli moduli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Wondering if it's worth somehow posting a comment to the PR when it fails. Just an idea.

@johanbrandhorst johanbrandhorst force-pushed the jbrandhorst-refuse-backports-of-migrations branch from 759aff4 to 2964acb Compare August 23, 2024 17:58
@johanbrandhorst
Copy link
Collaborator Author

Seems fine.

Wondering if it's worth somehow posting a comment to the PR when it fails. Just an idea.

Great idea, I stole the logic from the schema diff workflow, PTAL.

@johanbrandhorst johanbrandhorst merged commit 50ead47 into main Aug 23, 2024
61 of 63 checks passed
@johanbrandhorst johanbrandhorst deleted the jbrandhorst-refuse-backports-of-migrations branch August 23, 2024 19:07
jefferai pushed a commit that referenced this pull request Sep 11, 2024
@johanbrandhorst @jefferai
ci: refuse to backport if migrations changed (#5035)
82ea31c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moduli moduli moduli approved these changes

@jimlambrt jimlambrt Awaiting requested review from jimlambrt

@mgaffney mgaffney Awaiting requested review from mgaffney

@tmessi tmessi Awaiting requested review from tmessi

Assignees
No one assigned
Labels
core/db core/sql core
Projects
None yet
Milestone
0.18.x
Development

Successfully merging this pull request may close these issues.
2 participants
@johanbrandhorst @moduli