Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(host): validate ipv6 address for hosts #5052

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

ddebko
Copy link
Collaborator

@ddebko ddebko commented Aug 28, 2024

Summary

A new set of tests were added to the create/update repository methods of the static host resource. These tests were added to validate that an IPv6 address can be used by a host. The existing UpsertHost test for the dynamic host resource was updated to validate ensure an IPv6 address can be used by a host.

Copy link
Collaborator

@kheina kheina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddebko ddebko merged commit 89c9a30 into main Sep 5, 2024
59 of 63 checks passed
@ddebko ddebko deleted the ddebko-host-ipv6 branch September 5, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants