Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two fixes in our Go API code #5066

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Two fixes in our Go API code #5066

merged 1 commit into from
Sep 4, 2024

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Sep 3, 2024

  • Replace interface{} with any
  • For options that are bools, don't always set true; set to the actual value passed in (some options already behaved this way, but they all should)

@jefferai jefferai added this to the 0.17.x milestone Sep 3, 2024
@jefferai jefferai changed the title Two fixes in our Go API code: Two fixes in our Go API code Sep 3, 2024
@jefferai
Copy link
Member Author

jefferai commented Sep 3, 2024

Note: I plan to backport this to incorporate it into some other API work (mainly the bool consistency)

@jefferai
Two fixes in our Go API code:
f05ccec 
* Replace `interface{}` with `any`
* For options that are bools, don't always set true; set to the actual
  value passed in (some options already behaved this way, but they all
  should)
@jefferai jefferai requested a review from ddebko September 3, 2024 19:07
louisruch
louisruch approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, love how big these gen file changes always look in change counts

@jefferai jefferai merged commit 35d1df7 into main Sep 4, 2024
62 of 64 checks passed
@jefferai jefferai deleted the jefferai-fix-go-any-bools branch September 4, 2024 15:40
@hc-github-team-secure-boundary hc-github-team-secure-boundary mentioned this pull request Sep 4, 2024
Closed
jefferai added a commit that referenced this pull request Sep 4, 2024
@jefferai
Two fixes in our Go API code: (#5066)
9a89956 
* Replace `interface{}` with `any`
* For options that are bools, don't always set true; set to the actual
  value passed in (some options already behaved this way, but they all
  should)
jefferai added a commit that referenced this pull request Sep 4, 2024
@jefferai
Two fixes in our Go API code: (#5066)
7c2b77f 
* Replace `interface{}` with `any`
* For options that are bools, don't always set true; set to the actual
  value passed in (some options already behaved this way, but they all
  should)
jefferai added a commit that referenced this pull request Sep 11, 2024
@jefferai
Two fixes in our Go API code: (#5066) (#5073)
3b77ebe 
* Replace `interface{}` with `any`
* For options that are bools, don't always set true; set to the actual
  value passed in (some options already behaved this way, but they all
  should)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisruch louisruch louisruch approved these changes

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

@ddebko ddebko Awaiting requested review from ddebko

Assignees
No one assigned
Labels
api/authmethods api/authtokens api/groups api/hostcatalogs api/hosts api/hostsets api/roles api/scopes api/sessions api/targets api/users api backport/0.17.x core
Projects
None yet
Milestone
0.17.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @johanbrandhorst @louisruch