Some test fixes #5085
Merged
Some test fixes #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in #5071
Hosts contain IP addresses in string form, whose order is not defined.
johanbrandhorst
changed the title
mgaffney
approved these changes
Sep 7, 2024
mgaffney
reviewed
Sep 7, 2024
| @@ -95,7 +95,7 @@ func TestSessionConnectionCleanupJob(t *testing.T) { | |||
|
|
|||
| // Create the job. | |||
| job, err := newSessionConnectionCleanupJob(ctx, rw, gracePeriod) | |||
| job.gracePeriod = gracePeriod // by-pass factory assert so we dont have to wait so long | |||
| job.workerStatusGracePeriod = gracePeriod // by-pass factory assert so we dont have to wait so long | |||
There was a problem hiding this comment.
This is also needed on the main branch
There was a problem hiding this comment.
I would think the other change (not swagger) is as well. Maybe make this against main and then backport?
There was a problem hiding this comment.
Looks like those changes are part of this PR to main: #5084.
jefferai
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/session: update variable name in test
This was missed in #5071
internal/gen: regenerate files
internal/host/plugin: fix flaky test
Hosts contain IP addresses in string form, whose
order is not defined.