-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client cache API paging #5096
Closed
Closed
Client cache API paging #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
* refact: to use go-dbw CreateItems, DeleteItems Latest version of go-dbw updated the signature of CreateItems(...) and DeleteItems(...) on a happy note this latest version of go-dbw actually does batch inserts and updates for this functions. * all: regenerate protos with new protoc-gen-go version
* docs: Fix broken anchor link in Credential management * docs: Update link titles
* add changelog sections * doc: add changelog for storage bucket credential * add ui changes to changelog * fix indenting & parentheses --------- Co-authored-by: Danielle Miu <29378233+DanielleMiu@users.noreply.github.com> Co-authored-by: Elim Tsiagbey <elim.tsiagbey@hashicorp.com> Co-authored-by: Lisbet Alvarez <lisbet.alvarez@hashicorp.com>
* implement configurable getDownstreamWorker timeout * add parsing test * typos * fix tests * fix worker tests * 0 is a valid value
* test(e2e): Add test for worker api tags * CR: Add additional check for an API tag that's the same as a config tag
Other parts of CI do not fail on cache miss, and it might be necessary to allow it to fail to successfully restore it later.
all: upgrade Go to 1.23.0
Update GRPC Gateway tickets to compare tickets in constant-time
* docs: Update release notes * docs: Rephrase item * docs: Add Important changes table to 0.17.1 * docs: Add info about wget and health checks * docs: Fix typos * docs: Minor rewrite * code block fixes, style guide enhancements, metadata description refresh * docs: Update location of wget binary * docs: Fix bulleted list * Update website/content/docs/operations/health.mdx Co-authored-by: Sorawis Nilparuk (Bo) <sorawis.nilparuk@hashicorp.com> * docs: Updates based on feedback --------- Co-authored-by: stellarsquall <stellarsquall@protonmail.ch> Co-authored-by: Sorawis Nilparuk (Bo) <sorawis.nilparuk@hashicorp.com>
Add validation for the port number in LDAP URLs. If a port number is provided, it is checked to ensure it is a valid integer and within the valid range. This validation helps prevent errors when configuring LDAP authentication.
Using time.After makes the intent clearer
Add `WithDisablePathLengthFallback()` runtime option to the grpc-gateway mux HTTP server. This prevents the issue where the request method can be overridden with a `X-HTTP-Method-Override` header.
The API automatically paginates to the end of a pagination, and would take into account any items updated and subsequently removed since the last pagination. It now also removes any items removed during the current pagination.
johanbrandhorst
force-pushed
the
jbrandhorst-go-api-paging
branch
from
September 10, 2024 18:11
d54c7af
to
089c629
Compare
jefferai
force-pushed
the
llb-cache-speedup
branch
from
September 11, 2024 20:38
a6addfc
to
9efa378
Compare
jefferai
force-pushed
the
llb-cache-speedup
branch
2 times, most recently
from
September 11, 2024 21:36
22f440e
to
168a13d
Compare
Closing for #5107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.