Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate targets in cache #5101

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

jefferai
Copy link
Member

  • Update Go API to support pagination
  • Implement pagination of targets in cache

* Update Go API to support pagination
* Implement pagination of targets in cache
Copy link
Collaborator

@moduli moduli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some e2e test failures around listing resources. Are those expected?

paginate_credential_library_test.go:119: 
│         	Error Trace:	/src/boundary/testing/internal/e2e/tests/base_with_vault/paginate_credential_library_test.go:119
│         	Error:      	Received unexpected error:
│         	            	exit status 1
│         	Test:       	TestCliPaginateCredentialLibraries
│         	Messages:   	{"context":"Error from controller when performing list on credential libraries","status_code":400,"api_error":{"kind":"InvalidArgument","message":"Improperly formatted identifier.","details":{"request_fields":[{"name":"scope_id","description":"This field must be a valid project scope ID or the list operation must be recursive."}]}}}
paginate_user_test.go:58: 
│         	Error Trace:	/src/boundary/testing/internal/e2e/tests/base/paginate_user_test.go:58
│         	Error:      	Received unexpected error:
│         	            	exit status 1
│         	Test:       	TestCliPaginateUsers
│         	Messages:   	{"context":"Error from controller when performing list on users","status_code":400,"api_error":{"kind":"InvalidArgument","message":"Improperly formatted identifier.","details":{"request_fields":[{"name":"scope_id","description":"This field must be a valid project scope ID or the list operation must be recursive."}]}}}

etc.

Copy link
Collaborator

@moduli moduli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests are fixed

@jefferai jefferai merged commit e72712c into llb-cache-speedup Sep 12, 2024
53 of 55 checks passed
@jefferai jefferai deleted the jefferai-go-api-paging branch September 12, 2024 19:56
@jefferai jefferai restored the jefferai-go-api-paging branch September 12, 2024 19:56
@jefferai jefferai deleted the jefferai-go-api-paging branch September 12, 2024 19:56
jefferai added a commit that referenced this pull request Sep 18, 2024
* Update Go API to support pagination
* Implement pagination of targets in cache
tmessi pushed a commit that referenced this pull request Sep 23, 2024
* Update Go API to support pagination
* Implement pagination of targets in cache
tmessi pushed a commit that referenced this pull request Sep 24, 2024
* Update Go API to support pagination
* Implement pagination of targets in cache

(cherry picked from commit cd25fad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants