-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paginate targets in cache #5101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jefferai
commented
Sep 11, 2024
- Update Go API to support pagination
- Implement pagination of targets in cache
jefferai
force-pushed
the
jefferai-go-api-paging
branch
from
September 11, 2024 18:03
73bf790
to
ba85f34
Compare
irenarindos
reviewed
Sep 11, 2024
jefferai
force-pushed
the
llb-cache-speedup
branch
from
September 11, 2024 20:34
94ac01b
to
a6addfc
Compare
jefferai
force-pushed
the
llb-cache-speedup
branch
2 times, most recently
from
September 11, 2024 21:16
9efa378
to
22f440e
Compare
jefferai
force-pushed
the
jefferai-go-api-paging
branch
from
September 11, 2024 21:18
ba85f34
to
54d2fad
Compare
jefferai
force-pushed
the
llb-cache-speedup
branch
from
September 11, 2024 21:36
22f440e
to
168a13d
Compare
* Update Go API to support pagination * Implement pagination of targets in cache
jefferai
force-pushed
the
jefferai-go-api-paging
branch
from
September 11, 2024 21:37
54d2fad
to
945c090
Compare
irenarindos
approved these changes
Sep 12, 2024
moduli
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some e2e test failures around listing resources. Are those expected?
paginate_credential_library_test.go:119:
│ Error Trace: /src/boundary/testing/internal/e2e/tests/base_with_vault/paginate_credential_library_test.go:119
│ Error: Received unexpected error:
│ exit status 1
│ Test: TestCliPaginateCredentialLibraries
│ Messages: {"context":"Error from controller when performing list on credential libraries","status_code":400,"api_error":{"kind":"InvalidArgument","message":"Improperly formatted identifier.","details":{"request_fields":[{"name":"scope_id","description":"This field must be a valid project scope ID or the list operation must be recursive."}]}}}
paginate_user_test.go:58:
│ Error Trace: /src/boundary/testing/internal/e2e/tests/base/paginate_user_test.go:58
│ Error: Received unexpected error:
│ exit status 1
│ Test: TestCliPaginateUsers
│ Messages: {"context":"Error from controller when performing list on users","status_code":400,"api_error":{"kind":"InvalidArgument","message":"Improperly formatted identifier.","details":{"request_fields":[{"name":"scope_id","description":"This field must be a valid project scope ID or the list operation must be recursive."}]}}}
etc.
moduli
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests are fixed
jefferai
added a commit
that referenced
this pull request
Sep 18, 2024
* Update Go API to support pagination * Implement pagination of targets in cache
tmessi
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Update Go API to support pagination * Implement pagination of targets in cache
tmessi
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Update Go API to support pagination * Implement pagination of targets in cache (cherry picked from commit cd25fad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.