Don't explode grants from the DB #5104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/iam
api
core/session
core
core/perms
core/target
core/sql
core/daemon
labels
This removes the Cartesian product in the DB for GrantsForUser in favor of returning the actual grant scope information and dealing with it in application code. Pagination for resolvable aliases is yet to come, the rest should be done and pass local tests.
jefferai
force-pushed
the
jefferai-no-splode
branch
from
dc6dbc0
to
27f47e0
Compare
tmessi
reviewed
Sep 12, 2024
jefferai
force-pushed
the
jefferai-no-splode
branch
from
96aa09e
to
32dd64e
Compare
jefferai
force-pushed
the
jefferai-no-splode
branch
from
4723a73
to
18cfa1c
Compare
tmessi
approved these changes
Sep 16, 2024
louisruch
approved these changes
Sep 17, 2024
mgaffney
approved these changes
Sep 17, 2024
jefferai
added a commit
that referenced
this pull request
Sep 18, 2024
This removes the Cartesian product in the DB for GrantsForUser in favor of returning the actual grant scope information and dealing with it in application code.
tmessi
pushed a commit
that referenced
this pull request
Sep 23, 2024
This removes the Cartesian product in the DB for GrantsForUser in favor of returning the actual grant scope information and dealing with it in application code.
tmessi
pushed a commit
that referenced
this pull request
Sep 24, 2024
This removes the Cartesian product in the DB for GrantsForUser in favor of returning the actual grant scope information and dealing with it in application code. (cherry picked from commit 913cd53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops us from doing a Cartesian product on grants and scopes. Unfortunately, the DB part was easy; a lot of other code relied on the idea that any grant from the DB would be exploded, so the vast majority of the changes are adapting the rest of the system.