Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test to ensure ipv6 compatability #5113

Merged
merged 1 commit into from
Sep 19, 2024
Merged

test: improve test to ensure ipv6 compatability #5113

merged 1 commit into from
Sep 19, 2024

Conversation

ddebko
Copy link
Collaborator

@ddebko ddebko commented Sep 17, 2024

No description provided.

@ddebko ddebko requested a review from kheina September 17, 2024 22:52
kheina
kheina requested changes Sep 18, 2024
View reviewed changes
internal/tests/api/targets/target_test.go Outdated Show resolved Hide resolved
@ddebko ddebko requested a review from kheina September 18, 2024 21:11
kheina
kheina approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@kheina kheina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming relevant tests pass)

@ddebko ddebko merged commit 9576ed4 into main Sep 19, 2024
61 of 62 checks passed
@ddebko ddebko deleted the ddebko-localhost-ipv6-tests branch September 19, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kheina kheina kheina approved these changes

Assignees
No one assigned
Labels
api core/auth core/server core/session core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddebko @kheina