fix(session): Fix query for orphaned connections #5138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisruch
reviewed
Sep 27, 2024
tmessi
reviewed
Sep 27, 2024
| or | ||
| upper(connected_time_range) > now() | ||
| ) | ||
| %s |
There was a problem hiding this comment.
I think we should see if we can avoid this %s by always including this last clause, but also switch it to an any, ie:
and not (public_id = any(@reported_connection_ids))
irenarindos
approved these changes
Sep 27, 2024
mgaffney
force-pushed
the
mgaffney-fix-orphan-conn-query
branch
from
d9b1de3
to
276d1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.