Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Add retry to search test #5187

Merged
merged 1 commit into from
Oct 18, 2024
Merged

test(e2e): Add retry to search test #5187

merged 1 commit into from
Oct 18, 2024

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Oct 18, 2024

Potentially with the implementation of #5173, the e2e test for search was impacted and started to fail on main (in CI only (?). I couldn't repro locally).

 │ === RUN   TestCliSearch
│     search_test.go:40: Stopping daemon...
│     search_test.go:58: Waiting for daemon to start...
│     scope.go:85: Created Org Id: o_Mi5dwTRE8G
│     scope.go:127: Created Project Id: p_swelCH9fAZ
│     search_test.go:109: 
│         	Error Trace:	/src/boundary/testing/internal/e2e/tests/base/search_test.go:109
│         	Error:      	"[]" should have 1 item(s), but has 0
│         	Test:       	TestCliSearch
│ --- FAIL: TestCliSearch (6.15s)

This PR makes some modifications to the e2e test to perform some retries for that assertion.

@moduli moduli added the pr/no-milestone Ignores the Milestone Check label Oct 18, 2024
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@moduli moduli merged commit 50db63b into main Oct 18, 2024
65 checks passed
@moduli moduli deleted the moduli-e2e-search-update branch October 18, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-milestone Ignores the Milestone Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants