Fixing signatures in Hds::Flyout & Hds::Modal subcomponents (#2511)

Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Co-authored-by: Alex <alex-ju@users.noreply.github.com>

.changeset/dull-lamps-retire.md

@@ -0,0 +1,9 @@
+---
+"@hashicorp/design-system-components": patch
+---
+
+`Hds::Flyout`
+- Fixed error in `Description` and `Body` subcomponents, caused by not passing the `args` argument from the constructor to `super` 
+
+`Hds::Modal`
+- Fixed error in `Body` subcomponent, caused by not passing the `args` argument from the constructor to `super`

packages/components/src/components/hds/flyout/body.ts

@@ -7,15 +7,18 @@ import Component from '@glimmer/component';
 import { deprecate } from '@ember/debug';
 
 export interface HdsFlyoutBodySignature {
+  // when component has no args, but constructor still needs to be defined, use `never`
+  // see: https://github.com/hashicorp/design-system/pull/2511/files/f2146e5243d0431892a62d2fbf2889f1cbd3e525#r1815255004
+  Args: never;
   Blocks: {
     default: [];
   };
   Element: HTMLDivElement;
 }
 
 export default class HdsFlyoutBody extends Component<HdsFlyoutBodySignature> {
-  constructor(owner: unknown) {
-    super(owner, {});
+  constructor(owner: unknown, args: HdsFlyoutBodySignature['Args']) {
+    super(owner, args);
 
     deprecate(
       'The `Hds::Flyout::Body` sub-component is now deprecated and will be removed in the next major version of `@hashicorp/design-system-components`. Use `Hds::DialogPrimitive::Body` as one-to-one replacement.',

packages/components/src/components/hds/flyout/description.ts

@@ -8,15 +8,16 @@ import { deprecate } from '@ember/debug';
 import type { HdsTextBodySignature } from '../text/body';
 
 export interface HdsFlyoutDescriptionSignature {
+  Args: never;
   Blocks: {
     default: [];
   };
   Element: HdsTextBodySignature['Element'];
 }
 
 export default class HdsFlyoutDescription extends Component<HdsFlyoutDescriptionSignature> {
-  constructor(owner: unknown) {
-    super(owner, {});
+  constructor(owner: unknown, args: HdsFlyoutDescriptionSignature['Args']) {
+    super(owner, args);
 
     deprecate(
       'The `Hds::Flyout::Description` sub-component is now deprecated and will be removed in the next major version of `@hashicorp/design-system-components`. Use `Hds::DialogPrimitive::Description` as one-to-one replacement.',

packages/components/src/components/hds/modal/body.ts

@@ -7,15 +7,18 @@ import Component from '@glimmer/component';
 import { deprecate } from '@ember/debug';
 
 export interface HdsModalBodySignature {
+  // when component has no args, but constructor still needs to be defined, use `never`
+  // see: https://github.com/hashicorp/design-system/pull/2511/files/f2146e5243d0431892a62d2fbf2889f1cbd3e525#r1815255004
+  Args: never;
   Blocks: {
     default: [];
   };
   Element: HTMLDivElement;
 }
 
 export default class HdsModalBody extends Component<HdsModalBodySignature> {
-  constructor(owner: unknown) {
-    super(owner, {});
+  constructor(owner: unknown, args: HdsModalBodySignature['Args']) {
+    super(owner, args);
 
     deprecate(
       'The `Hds::Modal::Body` sub-component is now deprecated and will be removed in the next major version of `@hashicorp/design-system-components`. Use `Hds::DialogPrimitive::Body` as one-to-one replacement.',