Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Getting started for Engineers documentation to include marketing and email "targets" #2462

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Sep 27, 2024

📌 Summary

Small PR to address this comment/suggestion: #1965 (review)

🛠️ Detailed description

In this PR I have:

  • added entries for “Cloud UI email templating” and “HashiCorp web/marketing websites” to the explanation of how to consume the HDS design tokens in the “Getting started for engineers” documentation page

Preview: https://hds-website-git-update-getting-started-for-engineers-hashicorp.vercel.app/getting-started/for-engineers#tokens

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3201


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

…eting websites” to the explanation of how to consume the HDS design tokens in the “Getting started for engineers” documentation page
@didoo didoo requested a review from alex-ju September 27, 2024 14:03
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Sep 27, 2024 2:05pm
hds-website ✅ Ready (Inspect) Visit Preview Sep 27, 2024 2:05pm

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not sure about the best format for import notation, otherwise great additions

website/docs/getting-started/for-engineers.md Show resolved Hide resolved
@didoo didoo merged commit 92a9b4c into main Sep 27, 2024
10 checks passed
@didoo didoo deleted the update-getting-started-for-engineers branch September 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants