Update checkmark ListItem styling
#2464
Merged
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alex-ju
reviewed
Sep 30, 2024
There was a problem hiding this comment.
It doesn't allow me to suggest on removed lines, so I'm leaving a comment here for how we can simplify the CSS and achieve the same result
.hds-dropdown-list-item--variant-checkmark-selected {
.hds-dropdown-list-item__checkmark {
color: var(--token-color-foreground-action);
}
}
main points:
color: var(--token-color-foreground-primary);is set by the color modifier, so no need to override it onhds-dropdown-list-item__interactive.hds-dropdown-list-item__checkmarkdoesn't need to be nested underhds-dropdown-list-item__interactive
|
Thanks for the suggestion @alex-ju ! That does indeed simplify things, I've incorporated that change |
alex-ju
approved these changes
Oct 1, 2024
KristinLBradley
approved these changes
Oct 1, 2024
heatherlarsen
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks great! Thanks for the quick update.
cc @Dhaulagiri Here's one other visual change I forgot to mention in our chat today coming out of the Figma v2.0 work
|
@KristinLBradley thanks for the suggestion, I've added a bit more context here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged this PR will update the styling of the selected state checkmark
ListItemin theDropdownto match the other variants.🛠️ Detailed description
Currently, the selected state of the checkmark
ListItemstyles the icon, label, and checkmark withForeground / Action, which differs from the selected state of the otherListItem's where the icon and label persist the usage ofForeground / Primary.However, because the checkmark variant is slightly different in interaction, I have left the hover and active states unchanged, only the resting/default state of the selected checkmark has been updated.
📸 Screenshots
Before
After
🔗 External links
Jira ticket: HDS-3895
Figma file: Figma v2.0 Library | Dropdown
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.