Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeBlock - Expose ability to set custom line number start #2467

Merged
merged 2 commits into from
Oct 7, 2024
Merged

CodeBlock - Expose ability to set custom line number start #2467

merged 2 commits into from
Oct 7, 2024

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Oct 1, 2024 •
edited
Loading

📌 Summary

If merged, this PR will add the ability to set a custom line numbering starting number to the CodeBlock component.

🔗 External links

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Oct 1, 2024 8:50pm
hds-website ✅ Ready (Inspect) Visit Preview Oct 1, 2024 8:50pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website showcase labels Oct 1, 2024
@KristinLBradley
Copy link
Contributor Author

KristinLBradley commented Oct 1, 2024 •
edited
Loading

I was unable to figure out a way to test the custom line numbers as they are added in CSS and not in the DOM.

@KristinLBradley KristinLBradley requested a review from a team October 1, 2024 18:59
@KristinLBradley KristinLBradley marked this pull request as ready for review October 1, 2024 20:27
@KristinLBradley KristinLBradley force-pushed the code-block-add-line-number-start-option branch from d36f2b2 to 70beb72 Compare October 1, 2024 20:46
MelSumner
MelSumner approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a super useful feature when writing tutorials or guides that have segments that build on each other.

@KristinLBradley
Copy link
Contributor Author

@alex-ju Would it be ok if I go ahead and merge this feature? I think it's a generally useful feature for consumers.

@zamoore
Copy link
Contributor

zamoore commented Oct 3, 2024

Nice! Great work on this

@alex-ju
Copy link
Member

alex-ju commented Oct 7, 2024

@alex-ju Would it be ok if I go ahead and merge this feature? I think it's a generally useful feature for consumers.

I'm ok with merging it. We can monitor its usage in the long run.

@KristinLBradley KristinLBradley merged commit dd06a1b into main Oct 7, 2024
14 checks passed
@KristinLBradley KristinLBradley deleted the code-block-add-line-number-start-option branch October 7, 2024 20:50
@hashibot-hds hashibot-hds mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shleewhite shleewhite shleewhite approved these changes

@zamoore zamoore zamoore approved these changes

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website packages/components showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KristinLBradley @zamoore @alex-ju @MelSumner @shleewhite @hashibot-hds