SideNav - A11y improvements
#2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shleewhite
approved these changes
Nov 1, 2024
alex-ju
reviewed
Nov 4, 2024
There was a problem hiding this comment.
We should check for usage of @ariaLabel in <Hds::SideNav /> in our products before removing it. If no instances are found we should update the docs as well.
A more careful approach would be to keep the @ariaLabel argument, update the getter to return this.args.ariaLabel, and deprecate it.
|
@alex-ju I couldn't find uses of the (Search: https://github.com/search?q=org%3Ahashicorp+%22%3CHds%3A%3ASideNav+%22&type=code) |
alex-ju
reviewed
Nov 4, 2024
alex-ju
reviewed
Nov 4, 2024
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR makes a11y related improvements to the
SideNavrelated to List::Title headers and the ToggleButton aria properties following work done in the deprioritizedAppSideNav.🛠️ Detailed description
Implemented changes:
List::Titleto h3 & add visually hidden h2 to AppSideNav - Reference commentToggleButtonstate & use aria-expanded - Reference comment🔗 External links
AppSideNav- improvements for headers & aria (HDS-3897) #2463👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.