Website tabs - Set focus on tab change #2561
Open
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dchyun
force-pushed
the
dchyun/website-tabs-focus
branch
from
4b4ee09
to
98eb97a
Compare
didoo
reviewed
Nov 19, 2024
hashibot-hds
removed
the
docs-website
didoo
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will update the website tabs to maintain focus on the selected tab on tab change.
🛠️ Detailed description
Originally raised during the recent PR to make the website tabs sticky. It was raised that the focus should remain on the tab clicked after tab change. Tab click changes the ember route, and the current standard A11y pattern followed for route changes is to reset the user's focus and announce the changes leveraging the ember-a11y-refocus library.
It was determined that for tab changes that even though they trigger a route changes, the preferred interaction would be to have the user's focus remain on the selected tab. This was accomplished by updating the
@routeChangeValidatorargument of theNavigationNarrator.Note: The presence of tabs on a page is determined by checking if the
.doc-page-tabsHTML element is present.🔗 External links
Jira ticket: HDS-4150
💬 Please consider using conventional comments when reviewing this PR.