Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Website tabs grid structure #2566

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Nov 15, 2024

📌 Summary

If merged this PR would fix a bug on the website components pages, where there is extra spacing added between the content and the tabs, if the content is shorter than the height of the window. This bug was introduced during the recent update to make the tabs sticky.

📸 Screenshots

Current View:
Screenshot 2024-11-15 at 5 06 18 PM

Expected View:
Screenshot 2024-11-15 at 5 06 37 PM

🔗 External links

Jira ticket: HDS-3297

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Nov 15, 2024 10:09pm
hds-website ✅ Ready (Inspect) Visit Preview Nov 15, 2024 10:09pm

Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@dchyun dchyun merged commit e514a96 into main Nov 15, 2024
10 checks passed
@dchyun dchyun deleted the dchyun/fix-website-tabs-spacing branch November 15, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants