-
Notifications
You must be signed in to change notification settings - Fork 49
Guard against accessing hdsIntl service after component destruction
#3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7727964 to
282acdd
Compare
Member
Author
|
Seems to not fail atm – will close for now. |
282acdd to
0e28b08
Compare
Member
Author
|
Reopening this as it resurfaced as an issue in our tests |
shleewhite
approved these changes
Dec 5, 2025
5 tasks
3 tasks
Member
Author
|
I’ll merge this – if you have any concerns leave a comment and I'll follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Adds a safeguard in the
AdvancedTablecomponent to prevent accessing thehdsIntlservice after the component has been destroyed, avoiding potential runtime errors. This is addressing the most common case ofembroider-safetests failing in our library.🔗 External links
main👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.