Skip to content

Conversation

@alex-ju
Copy link
Member

@alex-ju alex-ju commented Sep 17, 2025

📌 Summary

Adds a safeguard in the AdvancedTable component to prevent accessing the hdsIntl service after the component has been destroyed, avoiding potential runtime errors. This is addressing the most common case of embroider-safe tests failing in our library.

🔗 External links


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Dec 5, 2025 2:07pm
hds-website Ready Ready Preview Dec 5, 2025 2:07pm

@alex-ju
Copy link
Member Author

alex-ju commented Sep 18, 2025

Seems to not fail atm – will close for now.

@alex-ju alex-ju closed this Sep 18, 2025
@alex-ju alex-ju deleted the alex-ju/fix-service-access-in-advanced-table branch September 18, 2025 16:11
@alex-ju alex-ju restored the alex-ju/fix-service-access-in-advanced-table branch December 5, 2025 13:55
@alex-ju alex-ju reopened this Dec 5, 2025
@alex-ju
Copy link
Member Author

alex-ju commented Dec 5, 2025

Reopening this as it resurfaced as an issue in our tests

@alex-ju alex-ju marked this pull request as ready for review December 5, 2025 14:29
@alex-ju alex-ju requested a review from a team as a code owner December 5, 2025 14:29
@alex-ju
Copy link
Member Author

alex-ju commented Dec 8, 2025

I’ll merge this – if you have any concerns leave a comment and I'll follow up

@alex-ju alex-ju merged commit 68f7b53 into main Dec 8, 2025
15 checks passed
@alex-ju alex-ju deleted the alex-ju/fix-service-access-in-advanced-table branch December 8, 2025 10:49
@hashibot-hds hashibot-hds mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants