update copyright headers & automation #772
Open
+192
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #770 (I can also push this change to that branch, if I'm throwing off tracking by opening a new PR instead of modifying that one). I've updated the files that generate copyrightheaders (.copywrite.hcl and hclsyntax/expression_vars_gen.go).
Note that our copyright tool doesn't accept multiple years under the copyright year attribute, so I included the years in the copyright_holder attribute. I tested locally that it looks correct on new files:
I also removed the older syntax build tags to appease the linter, though I suspect it's more correct to remove both (version) tags (only when it's a go version tag; I wouldn't remove the tools build!) as we are building HCL with go 1.23 - I figured I'd do the minimum first and see if reviewers had preferences.
Related Issue
#770
How Has This Been Tested?
touch new.go
make copyrightfix
cat new.go
👀