driver tests

drivers/docker/driver_linux_test.go

@@ -16,7 +16,7 @@ import (
 	"github.com/hashicorp/nomad/client/testutil"
 	"github.com/hashicorp/nomad/helper/pointer"
 	tu "github.com/hashicorp/nomad/testutil"
-	"github.com/stretchr/testify/require"
+	"github.com/shoenig/test/must"
 )
 
 func TestDockerDriver_authFromHelper(t *testing.T) {
@@ -28,24 +28,24 @@ func TestDockerDriver_authFromHelper(t *testing.T) {
 
 	helperFile := filepath.Join(dir, "docker-credential-testnomad")
 	err := os.WriteFile(helperFile, helperContent, 0777)
-	require.NoError(t, err)
+	must.NoError(t, err)
 
 	path := os.Getenv("PATH")
 	t.Setenv("PATH", fmt.Sprintf("%s:%s", path, dir))
 
 	authHelper := authFromHelper("testnomad")
 	creds, err := authHelper("registry.local:5000/repo/image")
-	require.NoError(t, err)
-	require.NotNil(t, creds)
-	require.Equal(t, "hashi", creds.Username)
-	require.Equal(t, "nomad", creds.Password)
+	must.NoError(t, err)
+	must.NotNil(t, creds)
+	must.Eq(t, "hashi", creds.Username)
+	must.Eq(t, "nomad", creds.Password)
 
 	if _, err := os.Stat(filepath.Join(dir, "helper-get.out")); os.IsNotExist(err) {
 		t.Fatalf("Expected helper-get.out to exist")
 	}
 	content, err := os.ReadFile(filepath.Join(dir, "helper-get.out"))
-	require.NoError(t, err)
-	require.Equal(t, "registry.local:5000", string(content))
+	must.NoError(t, err)
+	must.Eq(t, "registry.local:5000", string(content))
 }
 
 func TestDockerDriver_PluginConfig_PidsLimit(t *testing.T) {
@@ -57,18 +57,18 @@ func TestDockerDriver_PluginConfig_PidsLimit(t *testing.T) {
 	driver.config.PidsLimit = 5
 
 	task, cfg, _ := dockerTask(t)
-	require.NoError(t, task.EncodeConcreteDriverConfig(cfg))
+	must.NoError(t, task.EncodeConcreteDriverConfig(cfg))
 
 	cfg.PidsLimit = 7
 	_, err := driver.createContainerConfig(task, cfg, "org/repo:0.1")
-	require.Error(t, err)
-	require.Contains(t, err.Error(), `pids_limit cannot be greater than nomad plugin config pids_limit`)
+	must.Error(t, err)
+	must.StrContains(t, err.Error(), `pids_limit cannot be greater than nomad plugin config pids_limit`)
 
 	// Task PidsLimit should override plugin PidsLimit.
 	cfg.PidsLimit = 3
 	opts, err := driver.createContainerConfig(task, cfg, "org/repo:0.1")
-	require.NoError(t, err)
-	require.Equal(t, pointer.Of(int64(3)), opts.HostConfig.PidsLimit)
+	must.NoError(t, err)
+	must.Eq(t, pointer.Of(int64(3)), opts.Host.PidsLimit)
 }
 
 func TestDockerDriver_PidsLimit(t *testing.T) {
@@ -80,7 +80,7 @@ func TestDockerDriver_PidsLimit(t *testing.T) {
 	cfg.PidsLimit = 1
 	cfg.Command = "/bin/sh"
 	cfg.Args = []string{"-c", "sleep 5 & sleep 5 & sleep 5"}
-	require.NoError(t, task.EncodeConcreteDriverConfig(cfg))
+	must.NoError(t, task.EncodeConcreteDriverConfig(cfg))
 
 	_, _, _, cleanup := dockerSetup(t, task, nil)
 	defer cleanup()
@@ -98,6 +98,6 @@ func TestDockerDriver_PidsLimit(t *testing.T) {
 		}
 		return true, nil
 	}, func(err error) {
-		require.NoError(t, err)
+		must.NoError(t, err)
 	})
 }