Skip to content

Commit

Permalink
consul: allow non-root Nomad to rewrite token (#24410)
Browse files Browse the repository at this point in the history
When a task restarts, the Nomad client may need to rewrite the Consul token, but
it's created with permissions that prevent a non-root agent from writing to
it. While Nomad clients should be run as root (currently), it's harmless to
allow whatever user the Nomad agent is running as to be able to write to it, and
that's one less barrier to rootless Nomad.

Ref: #23859 (comment)
  • Loading branch information
tgross authored Nov 19, 2024
1 parent dc50133 commit a420732
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/24410.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
consul: Fixed a bug where non-root Nomad agents could not recreate a task's Consul token on task restart
```
2 changes: 1 addition & 1 deletion client/allocrunner/taskrunner/consul_hook.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const (

// consulTokenFilePerms is the level of file permissions granted on the file in
// the secrets directory for the task
consulTokenFilePerms = 0440
consulTokenFilePerms = 0640
)

type consulHook struct {
Expand Down

0 comments on commit a420732

Please sign in to comment.