Small note on error handling

hashicorp · May 6, 2024 · b4aa1fe · b4aa1fe
1 parent fb02dbe
commit b4aa1fe
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/ui/app/components/job-row.js b/ui/app/components/job-row.js
@@ -186,14 +186,25 @@ export default class JobRow extends Component {
 
   @task(function* () {
     try {
-      yield this.args.job.latestDeployment.content.promote();
+      yield this.args.job.latestDeployment.content.promote(); // TODO: need to do a deployment findRecord here first.
       // dont bubble up
       return false;
     } catch (err) {
-      this.handleError({
-        title: 'Could Not Promote Deployment',
-        // description: messageFromAdapterError(err, 'promote deployments'),
-      });
+      // TODO: handle error. add notifications.
+      console.log('caught error', err);
+      // this.handleError({
+      //   title: 'Could Not Promote Deployment',
+      //   // description: messageFromAdapterError(err, 'promote deployments'),
+      // });
+
+      // err.errors.forEach((err) => {
+      //   this.notifications.add({
+      //     title: "Could not promote deployment",
+      //     message: err.detail,
+      //     color: 'critical',
+      //     timeout: 8000,
+      //   });
+      // });
     }
   })
   promote;