Skip to content

Commit

Permalink
hold point, breaks identified
Browse files Browse the repository at this point in the history
  • Loading branch information
philrenaud committed Aug 8, 2023
1 parent 7641f59 commit f327af0
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ui/app/components/job-page/parts/title.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ export default class Title extends Component {
const job = this.job;
const specification = yield job.fetchRawSpecification();
job.set('_newDefinition', specification.Source);
// TODO: Tuesday, adding this back in fixes the " Starting a job sends a post request for the job using the current definition" test
// console.log("bout to fetch");
// const definition = yield job.fetchRawDefinition();
// console.log("fetch'd", definition);
// delete definition.Stop;
// job.set('_newDefinition', JSON.stringify(definition));

try {
yield job.parse();
Expand Down
7 changes: 7 additions & 0 deletions ui/tests/integration/components/job-page/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ export async function purgeJob() {

export function expectStartRequest(assert, server, job) {
const expectedURL = jobURL(job);
// TODO: Tuesday, this is the part of the service test that's failing
console.log(
'expectStartRequest',
expectedURL,
job,
server.pretender.handledRequests
);
const request = server.pretender.handledRequests
.filterBy('method', 'POST')
.find((req) => req.url === expectedURL);
Expand Down
2 changes: 2 additions & 0 deletions ui/tests/integration/components/job-page/service-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ module('Integration | Component | job-page/service', function (hooks) {

await startJob();
expectStartRequest(assert, this.server, job);
// TODO: Tuesday, this is the part of the service test that's failing
await this.pauseTest();

Check failure on line 126 in ui/tests/integration/components/job-page/service-test.js

View workflow job for this annotation

GitHub Actions / pre-test

Do not use `pauseTest()`
});

test('Starting a job without proper permissions shows an error message', async function (assert) {
Expand Down

0 comments on commit f327af0

Please sign in to comment.