[ui] Search results are overloading filter with sorted results

[philrenaud]

Bit of context here:

• Our Searchable mixin uses fuzzy-finding, so both my jobs "fakepy" and "fails_after_10" will show up when I type "fai" or "fak" into my search bar
  
• Last year, we addressed a bug where sorting wouldn't apply at all if a search term was present in PR bug: sorting problem with text filter #15432
• More recently, we'd heard concerns that our search results appeared degraded from previous versions

This PR attempts to both preserve the ability to sort after searching, and not overload results with searched-but-not-ordered filter results by creating a new getter() that checks to see if any sorting has been applied.

[github-actions]

Ember Test Audit comparison

	main	da8f0de	change
passes	1498	1499	+1
failures	1	1	0
flaky	0	0	0
duration	000ms	000ms	-000ms

[lgfa29]

Code changes LGTM, just missing a changelog entry and that missing property.

But I think there may be a challenge in terms of being able to get the list sorted by the original search score, since when we sort results there's no way to "unsort" them.

One approach I though was for a search to always reset the sort order to the fuzzy score, but that could be annoying? But also, that's kind of what I expect to happen? 😅

[lgfa29]

Suggested change

	@computed('sortProperty', 'searchTerm')
	@computed('sortProperty', `sortDescending`, 'searchTerm')

[philrenaud]

@lgfa29

always reset the sort order to the fuzzy score

My worry here is that:

• search fai, both "fails" and "fakepy" show up, in that order
• click to sort by priority or something to change order
• nothing changes because fuzzy score isn't affected

I think that would break the expected experience from #14872, so I'm apprehensive to apply it.

[lgfa29]

Ah sorry, I think I didn't explain myself well. From your example the flow I was thinking would be like this:

1. search fai, fails, fails-2, and fakepy show up, in that order
2. click to sort by priority or something to change order
3. table is sorted according to selection
4. search for fail, only fails and fails-2 show up, ordered by their fuzzy score and previous order selection is removed.

So after a search users can sort results by whichever column they would like, but changing the search term resets the ordering to fuzzy score.

[philrenaud]

Got it, so what I'm currently calling unsortedSearchState might be better served as prioritizeSearchOrder or something, and is defaulted if the last thing that's taken place is a search. That sound right?

[lgfa29]

Hum...I think what's missing is a listener for changes to the search term that resets sortProperty and sortDescending to their default values. Then I believe unsortedSearchState (or prioritizeSearchOrder, it does sound like a better name) and sortedJobs would do the flow I described.

[lgfa29]

I think we still need to clear the sort query param to make the arrow disappear from the table header:

[philrenaud]

I think we still need to clear the sort query param to make the arrow disappear from the table header:
Only thing I'm worried about there is upon removing the search term, I expect the sort to be maintained. I could hide the arrow while the search is the most recent thing, butI'd need to re-establish it once the search term is removed.

[lgfa29]

Only thing I'm worried about there is upon removing the search term, I expect the sort to be maintained.

Wouldn't that be a new search? I think I would expect the table to reset to its original state (sorted by CreateIndex) 🤔

[philrenaud]

Yeah fair enough! That's actually the state I moved it to this morning, so I think I'll move forward with this.