Backport of [ui] Job Variables page into release/1.6.x #18106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/17937-allow-users-to-see-all-the-variables-from-the-job-page-including-groups-and-tasks/repeatedly-blessed-sunbeam
branch
2 times, most recently
from
049a410
to
fb44b78
Compare
hc-github-team-nomad-core
force-pushed
the
backport/17937-allow-users-to-see-all-the-variables-from-the-job-page-including-groups-and-tasks/repeatedly-blessed-sunbeam
branch
from
fb44b78
to
049a410
Compare
Ember Test Audit comparison
|
* Bones of a component that has job variable awareness * Got vars listed woo * Variables as its own subnav and some pathLinkedVariable perf fixes * Automatic Access to Variables alerter * Helper and component to conditionally render the right link * A bit of cleanup post-template stuff * testfix for looping right-arrow keynav bc we have a new subnav section * A very roundabout way of ensuring that, if a job exists when saving a variable with a pathLinkedEntity of that job, its saved right through to the job itself * hacky but an async version of pathLinkedVariable * model-driven and async fetcher driven with cleanup * Only run the update-job func if jobname is detected in var path * Test cases begun * Management token for variables to appear in tests * Its a management token so it gets to see the clients tab under system jobs * Pre-review cleanup * More tests * Number of requests test and small fix to groups-by-way-or-resource-arrays elsewhere * Variable intro text tests * Variable name re-use * Simplifying our wording a bit * parse json vs plainId * Addressed PR feedback, including de-waterfalling
philrenaud
force-pushed
the
backport/17937-allow-users-to-see-all-the-variables-from-the-job-page-including-groups-and-tasks/repeatedly-blessed-sunbeam
branch
from
049a410
to
272ae1e
Compare
philrenaud
deleted the
backport/17937-allow-users-to-see-all-the-variables-from-the-job-page-including-groups-and-tasks/repeatedly-blessed-sunbeam
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17964 to be assessed for backporting due to the inclusion of the label backport/1.6.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
A new route to:
A few new conventions added to facilitate good UX here: