[ui] Preserve HCL2 on stop/start via the web UI #18120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenomitch
approved these changes
Aug 1, 2023
Ember Test Audit comparison
|
shoenig
approved these changes
Aug 1, 2023
philrenaud
force-pushed
the
17806-nomad-job-stopstart-loses-submission
branch
from
ae83f7f
to
7802628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the start button shown here wouldn't be aware of the HCL2 job specification of a job, unless the user had previously navigated to the /definition page.
This PR makes it so that the specification is fetched immediately before attempting a
start.Resolves #17806