Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-msgpack to v2 2.1.1 #18812

Closed
wants to merge 5 commits into from
Closed

Commits on Oct 25, 2023

  1. Upgrade go-msgpack to v2 2.1.1

    And set the `time.Time` option to use the go-msgpack-1.1.5-compatible
    encoding in all the places, since that is the (now previous) version
    in `go.mod`.
    
    v2 2.1.1 was specifically designe to honor backwards compatibility
    with 1.1.5 and 0.5.5, and to clean up the code base to be more
    maintainable. There may performance lost with the 1.1.5 to 2.1.1
    migration since the fastpath code was removed, but the increased safety
    is probably worth it. See
    [the release notes for go-msgkack 2.1.0](https://github.com/hashicorp/go-msgpack/releases/tag/v2.1.0)
    for more details.
    
    I tested this by running this code, and booting up a cluster with
    a node also running the prior version of Nomad (before the upgrade).
    Before I made the changes to set the right `time.Time` option, the
    previous-version node would throw a bunch of time-decoding errors.
    After fixing the option, the node came up smoothly, even after
    changing leadership between them.
    
    This relies on
    - [ ] hashicorp/serf#705
    - [ ] hashicorp/raft-boltdb#38
    - [ ] hashicorp/raft#577
    - [ ] hashicorp/memberlist#292
    
    and maybe
    - [ ] hashicorp/net-rpc-msgpackrpc#12
    Christopher Swenson committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    84f9688 View commit details
    Browse the repository at this point in the history
  2. Update packages to temporary values for msgpack fix

    Christopher Swenson committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    4b97ffd View commit details
    Browse the repository at this point in the history
  3. remove client from go.mod

    Christopher Swenson committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b28874f View commit details
    Browse the repository at this point in the history
  4. go mod tidy

    Christopher Swenson committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    3794111 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Update dependencies

    Christopher Swenson committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f28cb59 View commit details
    Browse the repository at this point in the history