[gh-19729] Fix logic for updating terminal allocs on clients with max client disconnect #20181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanadelacuesta
force-pushed
the
b-gh-19729
branch
from
329db81
to
b602d23
Compare
Juanadelacuesta
force-pushed
the
b-gh-19729
branch
from
b602d23
to
c86fc5f
Compare
Juanadelacuesta
changed the title
Juanadelacuesta
force-pushed
the
b-gh-19729
branch
from
e9b8ee5
to
85a754e
Compare
tgross
approved these changes
Mar 22, 2024
Juanadelacuesta
force-pushed
the
b-gh-19729
branch
from
85a754e
to
34d61de
Compare
Co-authored-by: Tim Gross <tgross@hashicorp.com>
Juanadelacuesta
force-pushed
the
b-gh-19729
branch
from
54aee99
to
fafd938
Compare
Juanadelacuesta
added
release/1.6.x
backport/1.5.x
This was referenced Mar 28, 2024
Juanadelacuesta
added a commit
that referenced
this pull request
Mar 28, 2024
… client disconnect (#20181) Only ignore allocs on terminal states that are updated --------- Co-authored-by: Tim Gross <tgross@hashicorp.com>
Juanadelacuesta
added a commit
that referenced
this pull request
Mar 28, 2024
… client disconnect (#20181) Only ignore allocs on terminal states that are updated --------- Co-authored-by: Tim Gross <tgross@hashicorp.com>
Juanadelacuesta
added a commit
that referenced
this pull request
Mar 28, 2024
… client disconnect (#20181)
Juanadelacuesta
added a commit
that referenced
this pull request
Mar 28, 2024
… client disconnect (#20181) Only ignore allocs on terminal states that are updated --------- Co-authored-by: Tim Gross <tgross@hashicorp.com>
Juanadelacuesta
added a commit
that referenced
this pull request
Mar 28, 2024
Juanadelacuesta
added a commit
that referenced
this pull request
Apr 2, 2024
…nts with max client disconnect into release/1.6.x (#20249) * [gh-19729] Fix logic for updating terminal allocs on clients with max client disconnect (#20181) Only ignore allocs on terminal states that are updated --------- Co-authored-by: Tim Gross <tgross@hashicorp.com> * fix: update test --------- Co-authored-by: Juana De La Cuesta <juanita.delacuestamorales@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Juanadelacuesta <8647634+Juanadelacuesta@users.noreply.github.com>
Juanadelacuesta
added a commit
that referenced
this pull request
Apr 2, 2024
…nts with max client disconnect into release/1.7.x (#20248) * [gh-19729] Fix logic for updating terminal allocs on clients with max client disconnect (#20181) Only ignore allocs on terminal states that are updated --------- Co-authored-by: Tim Gross <tgross@hashicorp.com> * [gh-19729] Fix logic for updating terminal allocs on clients with max client disconnect (#20181) * fix: update test --------- Co-authored-by: Juana De La Cuesta <juanita.delacuestamorales@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Juanadelacuesta <8647634+Juanadelacuesta@users.noreply.github.com>
philrenaud
pushed a commit
that referenced
this pull request
Apr 18, 2024
… client disconnect (#20181) Only ignore allocs on terminal states that are updated --------- Co-authored-by: Tim Gross <tgross@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocations with enabled max_client_disconnect and on terminal states where being ignored and not updated, causing unexpected reconciliations.