Backport of jobspec: update gateway.ingress.service Consul API fields into release/1.7.x
#20194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Add support for further configuring `gateway.ingress.service` blocks to bring this block up-to-date with currently available Consul API fields (except for namespace and admin partition, which will need be handled under a different PR). These fields are sent to Consul as part of the job endpoint submission hook for Connect gateways. Co-authored-by: Horacio Monsalvo <horacio.monsalvo@southworks.com>
tgross
force-pushed
the
backport/CONSUL-681-consulIngressService-updated/firmly-fancy-bonefish
branch
from
50ea6bb
to
5b0ce3b
Compare
tgross
approved these changes
Mar 22, 2024
tgross
deleted the
backport/CONSUL-681-consulIngressService-updated/firmly-fancy-bonefish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20176 to be assessed for backporting due to the inclusion of the label backport/1.7.x.
🚨
The person who merged in the original PR is:
@tgross
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Add support for further configuring
gateway.ingress.serviceblocks to bring this block up-to-date with currently available Consul API fields (except for namespace and admin partition, which will need be handled under a different PR). These fields are sent to Consul as part of the job endpoint submission hook for Connect gatways.Replaces #16753, which I've rebased on
mainand added another commit that addresses a variety of documentation and style issues.Docs preview: https://nomad-32oz91834-hashicorp.vercel.app/nomad/docs/job-specification/gateway
Overview of commits