-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow client template config block to be parsed when using json config #24007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ncode! There should be tests in config_parse_test.go
that will exercise this code. We should make sure this bug fix is covered by those tests.
Also, can you run make cl
to add a changelog item for the bug fix?
@tgross cool, I'm going to work on that today! |
ad37034
to
83addc5
Compare
83addc5
to
ea97575
Compare
ea97575
to
a0c2259
Compare
a0c2259
to
2982d05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ncode! Test looks great but we need to get CI passing before we can merge. If you hclfmt
that one file, that should allow checks to pass and tests to run.
- Adds tests - Adds sample test data for parsing hcl and json - Adds changelog
2982d05
to
dd0b594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This will ship in the upcoming Nomad 1.9, with backports to Nomad Enterprise. Thanks again @ncode!
In #24007 we merged new HCL files but they were missing copywrite headers because the scan didn't run on this PR for some reason. I've already backported this to the Enterprise branches.
In #24007 we merged new HCL files but they were missing copywrite headers because the scan didn't run on this PR for some reason. I've already backported this to the Enterprise branches.
Btw I think the artifacts block will have the same problem
Fixes #24001