[ui] Modify variable access permissions for UI users with write in only certain namespaces #24073
+153
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
23905-operators-with-acl-limited-namespace-access-cant-easily-create-variable-in-nomadjobs-path
branch
from
07d10f5
to
ac78fcd
Compare
Ember Test Audit comparison
|
tgross
approved these changes
Sep 27, 2024
philrenaud
force-pushed
the
23905-operators-with-acl-limited-namespace-access-cant-easily-create-variable-in-nomadjobs-path
branch
from
33763cc
to
468dc16
Compare
tgross
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
LGTM
Long-term, I wonder if it wouldn't be a bad idea to model the backend's acl package directly so that we could run conformance tests between them. That would involve building out the radix trie datastructure we use there, so it's a bit of a lift, but we wouldn't need its transaction safety either.
.changelog/24073.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| ui: Fixes an issue where variables paths would not let namespaced users write variables unless they also had * namespace variable write permissions | |||
There was a problem hiding this comment.
I don't know for sure but I would bet that this breaks markdown in the changelog once we stitch all the text files together. Let's avoid the problem by writing it out:
Suggested change
| ui: Fixes an issue where variables paths would not let namespaced users write variables unless they also had * namespace variable write permissions | |
| ui: Fixes an issue where variables paths would not let namespaced users write variables unless they also had wildcard namespace variable write permissions |
philrenaud
force-pushed
the
23905-operators-with-acl-limited-namespace-access-cant-easily-create-variable-in-nomadjobs-path
branch
from
5656618
to
82f6a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the "Can this user write a variable?" logic so that users with a namespace.variable.write (but not allNamespaces.variable.write) get a "Create Variable" button.
Resolves #23905