Commits on Oct 1, 2024

1. scaling policy: use request namespace as target if unset in jobspec (#… …

   …24065)
   
   When jobs are submitted with a scaling policy, the scaling policy's target only
   includes the job's namespace if the `namespace` field is set in the jobspec and
   not from the request. Normally jobs are canonicalized in the RPC handler before
   being written to Raft. But the scaling policy targets are instead written during
   the conversion from `api.Job` to `structs.Job`. We populate the `structs.Job`
   namespace from the request here as well, but only after the conversion has
   occurred. Swap the order of these operations so that the conversion is always
   happening with a correct namespace.
   
   Long-term we should not be making mutations during conversion either. But we
   can't remove it immediately because API requests may come from any agent across
   upgrades. Move the scaling target creation into the `Canonicalize` method and
   mark it for future removal in the API conversion code path.
   
   Fixes: #24039

   

   tgross committed Oct 1, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 919f92c
   • Browse repository at this point

   Copy the full SHA

   919f92c View commit details

   Browse the repository at this point in the history