Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix script check execution #24098

Merged
merged 1 commit into from
Oct 1, 2024
Merged

docker: fix script check execution #24098

merged 1 commit into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. docker: fix script check execution

    In #24095 we made a fix for non-streaming exec into Docker tasks for script
    checks and `change_mode = "script"`, but didn't complete E2E testing. We need to
    use `ContainerExecAttach` in the new API in order to get stdout/stderr from
    tasklets, but the previous `ContainerExecStart` call will prevent this from
    running successfully with an error that the exec has already run.
    
    * Ref: [NET-11202 (comment)](https://hashicorp.atlassian.net/browse/NET-11202?focusedCommentId=551618)
    * This has shipped in Nomad 1.9.0-beta.1 but not production yet.
    * This should fix the remaining issues in nightly E2E for Docker.
    tgross committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8e05c82 View commit details
    Browse the repository at this point in the history