differently exclude tagged job versions from being pruned #24102
+31
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifically tagged versions that are not the latest
philrenaud
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23983 prevented tagged job versions from being pruned, but sometimes they would still count against
job_tracked_versions, which was not what we intended.This puts back the original old-version pruning logic, and instead filters out the tagged versions earlier (in
jobVersionByID()to avoid additional slice construction to filter the list inupsertJobVersion()), so that tagged versions are simply not considered during pruning at all.The test seems rather convoluted, but I opted to keep it because it exercises the holistic behavior that we want to see, while still also covering the more localized change to
jobVersionByID().