Backport of docker: fix a bug where auth for private registries wasn't parsed correctly into release/1.9.x #24230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/b-docker-auth/grossly-mint-tarpon
branch
from
4aac71f
to
1d8673c
Compare
pkazmierczak
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24215 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
In #23966 we introduced an official Docker client and did not notice that in contrast to our previous 3rd party client, the official SDK
PullOptionsobject expects a base64 encoded JSON with username and password, instead of username/password pair.This PR fixes the issue and adds e2e tests for Docker driver auth.
Fixes #24181
Internal ref: https://hashicorp.atlassian.net/browse/NET-11310
Overview of commits