Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade HDS dependency to 4.13 & migrate FlightIcon to Hds::Icon #24305

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Upgrade HDS dependency to 4.13 & migrate FlightIcon to Hds::Icon #24305

merged 4 commits into from
Oct 30, 2024

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Oct 27, 2024

Upgrade HDS dependency to 4.13 & migrate FlightIcon to Hds::Icon

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Ember Test Audit comparison

main ffaf17a change
passes 1581 1581 0
failures 0 0 0
flaky 0 0 0
duration 12m 14s 724ms 13m 32s 030ms +1m 17s 306ms

@zamoore zamoore self-assigned this Oct 28, 2024
@zamoore zamoore marked this pull request as ready for review October 28, 2024 20:31
philrenaud
philrenaud approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@philrenaud philrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the visual diffs are welcome changes. Thanks!

@philrenaud philrenaud added the backport/1.9.x backport to 1.9.x release line label Oct 29, 2024
@philrenaud philrenaud merged commit 00b88bd into main Oct 30, 2024
26 checks passed
@philrenaud philrenaud deleted the HDS-4.13 branch October 30, 2024 14:17
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrenaud philrenaud philrenaud approved these changes

Assignees

@zamoore zamoore

Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zamoore @philrenaud