Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] When your token expires and you sign in again, redirect to your original route. #24374

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Nov 5, 2024

When your token 403s or 500s (when it's deleted behind the scenes, or expires either while you're using the app, or while it's in your localStorage, say, overnight), this PR adds functionality to remember the page (and queryParams) you were on when it happened.

Upon signing back in (with a renewed token, say), you'll be automatically rerouted back to that page, with a little notification saying so.

Resolves #23793

@philrenaud philrenaud force-pushed the 23793-ui-when-a-token-is-expired-upon-re-authentication-take-me-back-to-the-route-i-came-from branch from bb8a7c9 to 372937d Compare November 6, 2024 22:51
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@philrenaud philrenaud force-pushed the 23793-ui-when-a-token-is-expired-upon-re-authentication-take-me-back-to-the-route-i-came-from branch from 9fa1904 to 4cbb2d0 Compare November 7, 2024 14:31
@philrenaud philrenaud added backport/1.9.x backport to 1.9.x release line and removed hcc/jira labels Nov 7, 2024
@philrenaud philrenaud merged commit 498b29b into main Nov 7, 2024
23 of 25 checks passed
@philrenaud philrenaud deleted the 23793-ui-when-a-token-is-expired-upon-re-authentication-take-me-back-to-the-route-i-came-from branch November 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] When a token is expired, upon re-authentication, take me back to the route I came from
2 participants