[ui] Fixes double-namespace-query-param when getting versions #24466
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
24444-versions-page-doesnt-load-diffs-in-namespace-scenarios
branch
from
5502d3a
to
c89365a
Compare
philrenaud
changed the title
schmichael
approved these changes
Nov 18, 2024
philrenaud
deleted the
24444-versions-page-doesnt-load-diffs-in-namespace-scenarios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24444
I was using a custom
+=-based url modifier to add the?diffVersionto the query to get job versions, ignoring that this was also happening in a nestedaddToPathmethod if other query params were inherently present — which is the case if the job has a non-default namespace.This resulted in a url like
job/:jobid/versions?namespace=myNS?diffs=true&diffVersion=3This PR fixes the double
?and lets the well-vested addToPath() handle all relevant URL param appending.To test, try applying a namespace, running a job within it, making a new version of it, and checking out the versions page. Before, you'd get 404s and "No changes"; now you should get 200s and version changes.