HostVolumePlugin interface and two implementations #24497
+488
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mkdir: HostVolumePluginMkdir: just creates a directory * example-host-volume: HostVolumePluginExternal: mkfs and mount loopback
send json PARAMETERS env var instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is functional end-to-end from CLI to Client, provided you place the
example-host-volumeplugin script in/opt/nomad/hostvolumeplugins/on the client node, or use the"mkdir"internal plugin.I have not tried this on MacOS or Windows, only my Linux laptop. Perhaps @pkazmierczak can test it on Mac for us? 🙂
There are many TODOs around, and no unit tests are present. Testing what's here is up next on my todo list, provided the overall shape of the interface here looks good to y'all.
The
_test-plugin.shscript was convenient for me sprucing up the example plugin, and gave me two ideas for future:nomadCLI subcommand might be neat to include, to ease plugin development for users_(or.or something) for library files