refactor: update esx5 to esxi

[tenthirtyam]

Description

• Updates references to "ESX5" to "ESXi".
• Sets remote_type of esxi as preferred and esx5 as deprecated.
• Updates messages and comments, including deprecation message.
• Updates tests to use more standard remote_type, remote_username, and remote_password.
• Updates description for the Config configuration.

Testing

Basic: ✅ PASS

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 took 7.6s 
➜ go fmt ./... 

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 
➜ make generate
2024/08/22 10:53:33 Copying "docs" to ".docs/"
2024/08/22 10:53:33 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 took 4.6s 
➜ make build

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.690s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    3.552s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    4.720s

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 took 15.3s 
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/packer-plugin-vmware/packer-plugin-vmware to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64

E2E: ✅ PASS

==> vmware-iso.appliance (shell-local): Running local shell script: /var/folders/dw/5mlbs0q50gs1qkqmgyx1g6dr0000gp/T/packer-shell1275577246
    vmware-iso.appliance (shell-local): > Setting the output and OVF paths ...
    vmware-iso.appliance (shell-local): > Moving the OVF files to ../output-appliance/appliance ...
    vmware-iso.appliance (shell-local): > Removing the ../output-appliance/appliance/appliance.mf file from the OVF directory ...
    vmware-iso.appliance (shell-local): > Adding the appliance version v0.0.1 to the OVF template ...
    vmware-iso.appliance (shell-local): > Creating the OVA file at ../output-appliance/appliance_v0.0.1.ova ..
    vmware-iso.appliance (shell-local): Opening OVF source: ../output-appliance/appliance/appliance.ovf
    vmware-iso.appliance (shell-local): Opening OVA target: ../output-appliance/appliance_v0.0.1.ova
    vmware-iso.appliance (shell-local): Writing OVA package: ../output-appliance/appliance_v0.0.1.ova
    vmware-iso.appliance (shell-local): Transfer Completed
    vmware-iso.appliance (shell-local): Warning:
    vmware-iso.appliance (shell-local):  - No manifest file found.
    vmware-iso.appliance (shell-local):  - No supported manifest(sha1, sha256, sha512) entry found for: 'appliance-disk1.vmdk'.
    vmware-iso.appliance (shell-local): Completed successfully
    vmware-iso.appliance (shell-local): > Removing files that are no longer required ...
    vmware-iso.appliance (shell-local): > Done!
Build 'vmware-iso.appliance' finished after 12 minutes 39 seconds.

==> Wait completed after 12 minutes 39 seconds

==> Builds finished. The artifacts of successful builds are:
--> vmware-iso.appliance: VM files in directory: output-appliance

Downloads/validated-solutions-for-cloud-foundation-d259796887ebaa52c50af4011be4b6d6526adc8f/appliance took 12m 43.4s 
✦5 ➜ 

And if using esx5 the following is logged:

2024/08/22 12:26:05 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64 plugin: 2024/08/22 12:26:05 Serving a plugin connection...
2024/08/22 12:26:05 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64 plugin: 2024/08/22 12:26:05 [TRACE] starting builder iso
2024/08/22 12:26:05 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64 plugin: 2024/08/22 12:26:05 The 'esx5' remote type is deprecated. Please use 'esxi' instead.
2024/08/22 12:26:05 [INFO] Starting internal plugin packer-provisioner-shell
2024/08/22 12:26:05 Starting plugin: /usr/local/bin/packer []string{"/usr/local/bin/packer", "execute", "packer-provisioner-shell"}

[tenthirtyam]

@nywilken - let's discuss if this should introduce a minimumEsxiVersion to support 7.0 and later.

[nywilken]

let me put sometime for tomorrow to discuss. I feel like this change plus ovf minimum version require a minor or even major.

[tenthirtyam]

Roger that. I was thinking minor. Let's's chat - been doggie in a bit on some issues and factoring that I see needed.

[tenthirtyam]

Ready for initial review; e2e validations are still in flight with the latest updates.

[lbajolet-hashicorp]

Left a comment on esx5 vs. esxi, but overall LGTM!

I'll let you address this and will come back later for another pass, but pre-approving in the meantime